Re: Compiler warnings fix

ITAGAKI Takahiro wrote:
> Peter Eisentraut <peter_e@gmx.net> wrote:
>
>   
>> ITAGAKI Takahiro wrote:
>>     
>>> Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c.
>>>
>>> There are following warnings if nls is enabled:
>>>     pg_locale.c: In function `pg_perm_setlocale':
>>>     pg_locale.c:161: warning: assignment discards qualifiers from pointer target type
>>> and if nls is disabled:
>>>     pg_locale.c:615: warning: 'IsoLocaleName' defined but not used
>>>
>>> There is also a warning in pg_regress.c:
>>>     pg_regress.c: In function `wait_for_tests':
>>>     pg_regress.c:1367: warning: passing arg 2 of `GetExitCodeProcess' from incompatible pointer type
>>>       
>> Which platform, which compiler, what configure options?
>>     
>
> It is in mingw, gcc.exe (GCC) 3.4.5 (mingw-vista special r3).
>
> There are same warning on vaquita in buildfarm.
> http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2009-01-26%20210011&stg=make
>
>
>   

Wouldn't we be better off using defined(ENABLE_NLS) instead of 
defined(LC_MESSAGES) ?

cheers

andrew