Re: [BUGS] BUG #4186: set lc_messages does not work

Magnus Hagander wrote:
> Hiroshi Inoue wrote:
>> Magnus Hagander wrote:
>>> Hiroshi Inoue wrote:
>>>>> AFAICS there are 2 causes.
>>>>>
>>>>> 1. MSVC version of postgres is using a bad gettext module.
>>>>> 2. getenv() in mingw cannot see the result of putenv() in MSVC8.0.
>>>>>
>>>>> As for 1, we have to use another gettext module. I can provide it
>>>>> if requested.
>>> Yes, I think that'll be needed. Exactly what is wrong and needs to be
>>> changed? (Copying DAve in on this since he builds the MSI)
>>>
>>> Is it possible to build this one with the same version of MSVC? If it
>>> is, then that should remove the need for #2, right?
>> Maybe so but what I built was gettext-0.17 and the README.woe32 says
>>
>>     This file explains how to create binaries for the mingw
>> execution             environment.....
>>     MS Visual C/C++ with "nmake" is no longer supported.
>>
>> BTW gettext-0.14.4 has both README.mingw and README.woe32. REAME.woe32
>> seems to be for MSVC build.
> 
> They are so annoying...
> 
> Anyway, if they don't support it, we shuldn't try to force it. Let's go
> down the path that they will have different ones, and make getenv() and
> friends update both.
> 
> Do you want to send an updated patch for it, or do you want me to look
> at it?

I would send a new patch to which I added a simple ISO style check for locale names.

regards,
Hiroshi Inoue