Re: Updates of SE-PostgreSQL 8.4devel patches (r1386)

Tom Lane wrote:
> "Robert Haas" <robertmhaas@gmail.com> writes:
>> I haven't looked at the patches, but one thing I'm concerned about is
>> the fact that it seems we still don't have a working implementation of
>> non-SEPostgresql column-level privileges.  Apparently, the latest
>> patch set from Stephen Frost doesn't handle those permissions when
>> joins are involved, which presumably means that it is not committable.
> 
> No, but it might be fixable.  I plan to look at that patch next after
> I have my immediate to-do items cleared off ...

Stephen, your patch appends attribute numbers on rte->cols_sel list,
even if the rte->relkind is RTE_JOIN.
Since ExecCheckRTEPerms() skips RangeTblEntry without RTE_RELATION,
it is necessary to care special case when the given rte->relkind has
RTE_JOIN, isn't it?

I think these attribute numbers should be chained on the source
RangeTblEntry of the joins to solve the issue.

Anyway, I hope your patch getting merged as soon as possible. :-)
If I have anything to help you, please feel free to ask for.

Thanks,
-- 
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>