Re: pgsql: Append major version number and for libraries soname major

Dave Page wrote:
> On Fri, Dec 12, 2008 at 12:41 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> petere@postgresql.org (Peter Eisentraut) writes:
>>> Log Message:
>>> -----------
>>> Append major version number and for libraries soname major version number
>>> to the gettext domain name, to simplify parallel installations.
>> The results from buildfarm member red_bat suggest that this commit broke
>> the MSVC build.  (I think that is the only MSVC buildfarm member that's
>> up at the moment.)
>>
>> Build FAILED.
>> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>> .\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
>>    0 Warning(s)
>>    3 Error(s)
>
> Any eta on a fix for this? My internal builds are failing as well as
> red_bat. (and yes, the other 2 MSVC buildfarm members are currently
> waiting for Dell to get hold of a new motherboard for their box).

I think the maintenance of the MSVC build system is the job of the,
well, maintainer of the MSVC build system, whoever that may be.  In
other words, I have no ETA for you from me.  I'd be glad, however, to
provide information to the maintainers.

The fix here is to define PG_MAJORVERSION near whereever you define
PG_VERSION, just make it look like "8.4" instead of "8.4devel".