Re: [REVIEW] (was Re: usermap regexp support)

Gianni Ciolli wrote:
> On Tue, Nov 11, 2008 at 02:59:01PM +0100, Magnus Hagander wrote:
>> Gianni Ciolli wrote:
>>>       WARNING:  detected write past chunk end in Postmaster 0x9b13650
>> Yes, that's a stupid bug:
> (...)
>> Attached is an updated version of the patch that fixes this.
> 
> Hi Magnus,
> 
> please find below the review of the second version of your patch,
> which I think is "Ready for Committer" now.

Thanks for a very thorough review! I'll incorporate your suggested
changes and do a commit soon.


> = En-passant remarks =
> 
>  * I found out that the comments in the pg_hba.conf file installed by
>    default are obsolete; we should either update them or replace them
>    with a reference to the Manual, chapter "Client Authentication",
>    section "the pg_hba.conf file".

I'll update the hba file for now - moving it to the manual and just
reference that is outside the scope of this patch.


//Magnus