Re: pgsql: Unite ReadBufferWithFork, ReadBufferWithStrategy, and

Simon Riggs wrote:
> On Fri, 2008-10-31 at 15:05 +0000, Heikki Linnakangas wrote:
>> Log Message:
>> -----------
>> Unite ReadBufferWithFork, ReadBufferWithStrategy, and ZeroOrReadBuffer
>> functions into one ReadBufferExtended function, that takes the strategy
>> and mode as argument. There's three modes, RBM_NORMAL which is the default
>> used by plain ReadBuffer(), RBM_ZERO, which replaces ZeroOrReadBuffer, and
>> a new mode RBM_ZERO_ON_ERROR, which allows callers to read corrupt pages
>> without throwing an error. The FSM needs the new mode to recover from
>> corrupt pages, which could happend if we crash after extending an FSM file,
>> and the new page is "torn".
>
> I thought you were adding the "read buffer only if in cache" option
> also?

No, but if it's needed, it should now fit well into the infrastructure,
as a new ReadBuffer mode.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com