Re: FSM, now without WAL-logging

Heikki Linnakangas napsal(a):
> Zdenek Kotala wrote:
>> I'm testing this version now and I got core dump in initdb phase:
>>
>> 08047558 pgstat_count_heap_insert+0x20(840b120, 842d738, 80, 8047580)

<snip>

>>
>> Let me know if you need more info. (I'm not using fresh CVS snapshot 
>> but two weeks old)
> 
> pgstat_count_heap_insert is an odd place to crash. I'd suggest updating 
> your CVS snapshot, and "make clean".

Updating is not good idea :( - not for performance test, because it will 
require retest original version and so on ...

> 
> Attached is a new version, now with WAL-logging of the FSM truncation. I 
> decided to go with the separate WAL record for that, rather than 
> piggybacking on the smgrtruncate's WAL record. It seems much better from 
> a modularity point of view this way. I've also worked on the comments, 
> renamed many of the internal functions, in a more coherent scheme, and I 
> also started using the "struct FSMAddress" you suggested a while ago.
> 
> But I don't think I've changed anything that could explain that crash. 
> Let me know if it still doesn't work.

OK. I'll look on it.
    Zdenek