A couple of patches, and other observations on pgadmin3
От | David Sainty |
---|---|
Тема | A couple of patches, and other observations on pgadmin3 |
Дата | |
Msg-id | 48DB368F.8000309@dtsp.co.nz обсуждение исходный текст |
Ответы |
Re: A couple of patches, and other observations on pgadmin3
|
Список | pgadmin-support |
Hi pgadmin3, There are a couple of places where variables look like they should be const. On my system, pgadmin3 will not build without these changes, bombing out with: error: invalid conversion from 'const wxChar*' to 'wxChar*' I should note that I'm using other hackery to allow a build with a non-Unicode wxGTK (2.8). It appears (from Google) that this kind of build failure only happens with non-Unicode wxGTK - though I can't imagine why that would be! I have to ask, why are you installing files world writable? ( http://svn.pgadmin.org/cgi-bin/viewcvs.cgi?rev=7141&view=rev ) Surely it's better to not install the cache file at all? Presumably it's an optional file, given the filename! Cheers, Dave $NetBSD$ --- pgadmin/frm/frmExport.cpp 2008-09-25 15:16:10.000000000 +1200 +++ pgadmin/frm/frmExport.cpp 2008-09-25 15:16:53.000000000 +1200 @@ -153,7 +153,7 @@ wxString line; long skipped = 0; - wxWX2MBbuf buf; + const wxWX2MBbuf buf; int colCount, rowCount; $NetBSD$ --- pgadmin/utils/utffile.cpp 2008-09-25 15:33:28.000000000 +1200 +++ pgadmin/utils/utffile.cpp 2008-09-25 15:33:48.000000000 +1200 @@ -102,7 +102,7 @@ if (m_conversion) { - wxWX2MBbuf buf = str.mb_str(*m_conversion); + const wxWX2MBbuf buf = str.mb_str(*m_conversion); if (!buf) return false;
В списке pgadmin-support по дате отправления: