Re: [PATCH] Add tests for Bitmapset

Поиск
Список
Период
Сортировка
От Greg Burd
Тема Re: [PATCH] Add tests for Bitmapset
Дата
Msg-id 48833E2B-C6E4-4C3D-A002-87234AF9782F@greg.burd.me
обсуждение исходный текст
Ответ на Re: [PATCH] Add tests for Bitmapset  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: [PATCH] Add tests for Bitmapset
Список pgsql-hackers
On Sep 29 2025, at 8:51 pm, Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote:
>> NULL is a valid Bitmapset, so I don't really see the need to check for
>> an empty set before calling bms_free().  If those were removed, then
>> you'd not have to care about the coverage of that line.

Good point, I agree.  Thanks for reporting/reviewing David.

> Yeah, we could just remove them as you are suggesting, as well.
> --
> Michael

Thank you both, patch attached.

best.

-greg

Вложения

В списке pgsql-hackers по дате отправления: