Re: Dialogs review

Dave Page a écrit :
> [Screenshots at http://developer.pgadmin.org/~dpage/Screenshots.zip]
>
> On Thu, Jul 10, 2008 at 1:45 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Dave Page a écrit :
>>> - There needs to be more of a border around the panes and between the
>>> contorls. The controls are very tight to the top, bottom and sides of
>>> the dialog (to the extend that the "I'm active" glow around controls
>>> is cut off on the top and right hand sides for instance. Similar
>>> eclipsing can be seen between controls. We probably just need an extra
>>> 2d or so everywhere.
>>>
>> Fixed on Linux and Win32.
>
> Yup, looks much better on Mac - in fact if anything it's gone a bit
> too far the other way. Maybe try 1 or 2d less than you've done. The
> SQL tab still needs similar treatment though.
>
> See the screenshots.
>

Fixed.

>>> - When resizing on the definition pane, the height of the list box
>>> increases, but doesn't decrease, so if you shrink the dialogue again,
>>> the controls at the bottom of the tab get hidden. The same does not
>>> happen on the properties page where the comments textbox resizes
>>> correctly.
>>>
>> I don't have the issue, neither on Linux, neither on Win32. Can you check
>> with this new patch? Thanks.
>
> Yes it still occurs :-(. The screenshots show what I mean.
>

Hmmmm, I see... that I can't do anything till I get my Mac. I will work
on it but I don't know now how to fix it.

>>> Aside from that, it does look good. Resizing of labels in different
>>> languages works nicely, and everything looks nice and consistent.
>>>
>>> Nice work :-)
>>>
>> Thanks. But something is bothering me. The status bar on the bottom of the
>> window doesn't seem to work on Windows, it seems to have disappeared.
>> dlgFunction seems to suffer the same issue but I didn't work on its xrc
>> file. And it works on Linux, for each dialog. Can you check on Mac and
>> Windows?
>
> It's there on the Mac (in both dialogs). I can't currently run Windows
> (other tasks already running in vmware), so cannot test there atm.
>
> A new problem on dlgCasts - the source and target type combo boxes are
> invisible unless I resize(!). I only need to enlarge the dialogue by
> 1px or so and they both magically appear. I suspect this is unrelated
> to the actual size, but perhaps we need to kick the sizers after
> loading the dialogue to force them to resize everything. If memory
> serves there's a recalculate function.
>

OK, I will write a new patch for each of them as soon as I can work on
the mac mini (but first I need to buy it).


--
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com