Re: pgsql: Fix a couple of bugs in win32 shmem name generation: * Don't cut

Magnus Hagander wrote:
> Heikki Linnakangas wrote:
>> Magnus Hagander wrote:
>>> Fix a couple of bugs in win32 shmem name generation:
>>> * Don't cut off the prefix. With this fix, it's again readable.
>>> * Properly store it in the Global namespace as intended.
>>>
>>> Tags:
>>> ----
>>> REL8_3_STABLE
>> What happens if someone launches version 8.3.3 postgres.exe and version
>> 8.3.4 postgres.exe at the same time, on the same data directory? Will
>> the interlock that prevents two postmasters from starting at the same
>> time work?
>
> Hmm. Didn't think of that :(
>
> Yeah, it seems that that part of it would fail. In a lot of cases you'd
> still get kicked off by socket conflicts and such, but the shared memory
> part would not notice someone is already there, no.

Yeah.

> Not sure if it's reason enough to revert - since it fixes other cases. I
> guess in theory we could check both the old and the new name, but that's
> going to be a considerably more complex patch.

Yeah, and it would still fail if you started the new version first, and
then the old one.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com