Re: [0/4] Proposal of SE-PostgreSQL patches

Tom Lane wrote:
> KaiGai Kohei <kaigai@ak.jp.nec.com> writes:
>> Tom Lane wrote:
>>> * It does not come close to passing the regression tests.  I saw a lot of
>>> ! ERROR:  unrecognized node type: 903
>>> which suggests that something's been screwed up about parse analysis
>>> (903 = T_A_Const, which shouldn't get further than parse analysis),
> 
>> Could you tell me what queries hit these errors?
> 
> I remember seeing it on some EXECUTEs, but you really ought to run the
> tests for yourself.  A *minimum* requirement on any submitted patch
> is that it should pass the regression tests.

Some of the test fails contains minor differences from expected results, like:

|   SELECT '' AS "xxx", *
|     FROM J1_TBL t1 (a, b, c) NATURAL JOIN J2_TBL t2 (d, a);
|    xxx | a | b |  c   | d
|   -----+---+---+------+---
|  -     | 0 |   | zero |
|        | 2 | 3 | two  | 2
|        | 4 | 1 | four | 2
|  +     | 0 |   | zero |
|   (3 rows)

and, some of them are trivial ones, like:

|   SELECT p1.oid, p1.typname
|   FROM pg_type as p1
|   WHERE p1.typtype in ('b','e') AND p1.typname NOT LIKE E'\\_%' AND NOT EXISTS
|       (SELECT 1 FROM pg_type as p2
|        WHERE p2.typname = ('_' || p1.typname)::name AND
|              p2.typelem = p1.oid and p1.typarray = p2.oid);
|  - oid | typname
|  ------+---------
|  - 210 | smgr
|  - 705 | unknown
|  -(2 rows)
|  + oid  |    typname
|  +------+----------------
|  +  210 | smgr
|  +  705 | unknown
|  + 3403 | security_label
|  +(3 rows)

Isn't it necessary to consider them as regressions?

Thanks,
-- 
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai@ak.jp.nec.com>