Re: get rid of psql welcome message
| От | Joshua D. Drake |
|---|---|
| Тема | Re: get rid of psql welcome message |
| Дата | |
| Msg-id | 480A14C4.4030105@commandprompt.com обсуждение исходный текст |
| Ответ на | Re: get rid of psql welcome message (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: get rid of psql welcome message
|
| Список | pgsql-hackers |
Tom Lane wrote: > Peter Eisentraut <peter_e@gmx.net> writes: >> I think everyone will find a mode they like here. > > +1. A marginal style suggestion: if you did > > var_welcome_message = GetVariable(pset.vars, "WELCOME_MESSAGE"); > if (!var_welcome_message) > var_welcome_message = ""; > > then the subsequent tests would not need null-guards and would become > much more readable IMHO. I would like to submit a further patch that has the one line screen (although I think it will be two), should I wait for this to be applied, apply it myself and write my patch against the modified tree, or just write my patch against head and let the committers figure it out? Joshua D. Drake
В списке pgsql-hackers по дате отправления: