Re: Proposed patch - psql wraps at window width

<br /><br /> Peter Eisentraut wrote: <blockquote cite="mid:200804171509.25472.peter_e@gmx.net" type="cite"><pre
wrap="">BruceMomjian wrote: </pre><blockquote type="cite"><pre wrap="">I checked the use of COLUMNS and it seems bash
updatesthe environment
 
variable when a window is resized.  I added ioctl(TIOCGWINSZ) if COLUMNS
isn't set.  We already had a call in print.c for detecting the
number of rows on the screen to determine if the pager should
be used.  Seems COLUMNS should take precedence over ioctl(), right?   </pre></blockquote><pre wrap="">
Considering that the code to determine the row count is undisputed so far, the 
column count detection should work the same.  That is, we might not need to 
look at COLUMNS at all.  Unless there is a use case for overriding the column 
count (instead of just turning off the wrapping). </pre></blockquote> I asked the folks over at "Experts Exchange" to
testthe behavior of the ioctl and $COLUMNS on various platforms.  I'd been told that I would face huge problems if a
consolewas resized.  But the results were pretty consistent, and nothing had problems with resize:  <a
class="moz-txt-link-freetext"
href="http://www.experts-exchange.com/Programming/Open_Source/Q_23243646.html">http://www.experts-exchange.com/Programming/Open_Source/Q_23243646.html</a><br
/><br/> It appears impossible to override $COLUMNS, on some platforms as the readline call sets it.<br /> On many
platforms$COLUMNS is null until the call to readline.<br /> OSX does not set $COLUMNS at all.<br /><br />             
           -Bryce<br /><br />