Re: Headers dependencies cleanup

Поиск
Список
Период
Сортировка
От Zdenek Kotala
Тема Re: Headers dependencies cleanup
Дата
Msg-id 47FA69F8.1040509@sun.com
обсуждение исходный текст
Ответ на Re: Headers dependencies cleanup  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-patches
Bruce Momjian napsal(a):
> Zdenek Kotala wrote:
>> Tom Lane napsal(a):
>>> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
>>>>>> During my work I found some header files, which include useless headers
>>>>>> and on other way there are some headers which silently assume that
>>>>>> requested header will be included by some other headers file.
>>>>> Bruce periodically runs a script that's supposed to catch this type
>>>>> of problem.  Maybe we are overdue for another run?
>>>> Yes, but This problem is there for long time and I think Bruce's script does not
>>>> catch it.
>>> Exactly what problem do you see that he didn't catch?
>> bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from
>> bufmgr.h. I think this dependency is there for long time.
>
> My scripts should have found this issue, see
> src/tools/pginclude/pgrminclude.
>

Hmmm. It is difficult to run it on Solaris. I adjusted scripts but I did not get
any change on current head.

        Zdenek

В списке pgsql-patches по дате отправления:

Предыдущее
От: "Tom Dunstan"
Дата:
Сообщение: Re: [HACKERS] Database owner installable modules patch
Следующее
От: Zdenek Kotala
Дата:
Сообщение: Re: Headers dependencies cleanup