Re: [COMMITTERS] pgsql: Enable probes to work with Mac OS X Leopard and other OSes that

Magnus Hagander wrote:
> Andrew Dunstan wrote:
>>
>>
>> Robert Lor wrote:
>>> Peter Eisentraut wrote:
>>>> Well, yes.  I meant to say, a build system that can supply the 
>>>> functionality of Gen_fmgrtab can surely implement this new thing.  
>>>> I see there is Perl being used, so it should be simple.
>>>>   
>>> I was thinking of using a Perl script to generate the dummy header 
>>> file but decided against it to avoid disrupting the build on other 
>>> platforms. If sed doesn't work on Windows for some reason, we can 
>>> use a Perl script instead.
>>>
>>>
>>
>> What we should do in fact is to use psed on Windows to execute the 
>> script. This is a sed emulator that is part of the standard perl 
>> install, and will save us the bother of having to maintain two 
>> generation scripts, or switching from sed to perl. We just need to 
>> find where to plug that into the Windows build process.
>
> Hadn't heard about that one. Sounds like a good way to do it, if you 
> can find the correct place for it :-)


I'm thinking of the patch below.  I'll try it out tomorrow.

cheers

andrew

Index: Solution.pm
===================================================================
RCS file: /cvsroot/pgsql/src/tools/msvc/Solution.pm,v
retrieving revision 1.36
diff -c -r1.36 Solution.pm
*** Solution.pm 28 Feb 2008 12:17:59 -0000      1.36
--- Solution.pm 20 Mar 2008 00:02:05 -0000
***************
*** 205,210 ****
--- 205,216 ----         close(T);     }
+     if 
(IsNewer('src\include\utils\probes.h','src\backend\utils\probes.d'))
+     {
+               print "Generating probes.h...\n";
+               system('psed -f src\backend\utils\Gen_dummy_probes.sed 
src\backend\utils\probes.d > src\include\utils\probes.h');
+       }
+     if 
(IsNewer('src\interfaces\libpq\libpq.rc','src\interfaces\libpq\libpq.rc.in'))     {         print "Generating
libpq.rc...\n";