Re: Proposed changes to DTrace probe implementation

Robert Lor wrote:
> Proposed changes:
> * Switch from using DTRACE_PROBEn macros to the dynamically generated 
> macros (remove pg_trace.h)
> * Use "dtrace -h" to create a header file that contains the 
> dynamically generated macros to be used in the source code instead of 
> the DTRACE_PROBEn macros.
> * Create a new header file called probes_null.h to map the generated 
> macros to no-ops
> * This is unrelated to making DTrace work on Leopard, but I'd like to 
> propose that we split the probes into generic database and Postgres 
> specific providers, called "database" and "postgresql" respectively. 
> Other databases will be adding DTrace probes as well, and we want to 
> use "database" as the provider for probes that are common to all 
> databases. This way scripts that use the common provider will work on 
> databases that implement the common probes.
>
Since I haven't heard any objections, I assume the proposed changes are 
acceptable. I'll go a head and submit the patch.

Regards,
-Robert