Re: Recent pg_regress changes break testing under SELinux

Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Tom Lane wrote:
>>> The original design had only the Makefile knowing exactly where the
>>> testtablespace directory lurks, making it changeable in one place,
>>> and also confining the whole business to src/test/regress which is good
>>> because none of the other uses of pg_regress need it.  As CVS tip
>>> stands, the location of testtablespace is hard-wired into the pg_regress
>>> executable, and I think it's mostly blind accident that it doesn't
>>> clutter contrib/* and src/pl/* with testtablespace directories.
> 
>> Commandline parameter, perhaps?
> 
> I was trying to avoid that, but only because it'd make the patch bigger.
> It would be one way to resolve the above gripes.
> 
> But I'm still thinking that it's fairly silly to expect Windows users to
> type out the equivalent of
> 
>     ./pg_regress --psqldir=$(PSQLDIR) --schedule=$(srcdir)/parallel_schedule --srcdir=$(abs_srcdir)
--multibyte=$(MULTIBYTE)--load-language=plpgsql $(MAXCONNOPT) $(NOLOCALE)
 


Yeah, agreed. The original idea was to have a shortcut created by the 
installer to do that for you.


> especially when no other platform is that hard.  (Admittedly, some of
> these switches have usable defaults, but many don't.)  So it really
> seems like the right answer is a .BAT script, and I'm kinda surprised
> to hear there's not one already.

Well, there is a way to run it from the msvc build. The idea was to be 
able to run after a binary install. Granted it doesn't make that much 
sense, but it was mostly a "customer feel good" thing. But there's 
nothing preventing that from being done from a .BAT file instead of a 
direct shortcut.

//Magnus