Re: pgbench enhancements

>> > Hi,
>> >
>> > I have committed contrib/pgbench enhanments contributed by Tomoaki
>> > Sato from SRA OSS, Inc. Japan.
>> >
>> > - predefined variable "tps"
>> >   The value of variable tps is taken from the scaling factor
>> >   specified by -s option.
>> >
>> > - -D option
>> >   Variable values can be defined by -D option.
>> >
>> > - \set command now allows arithmetic calculations.
>> >
>>
>>
>> Was there a previous patch posted for this? I don't recall seeing it.
>
> Are you saying that I should have posted patches and called for
> discussion? I omit the step because a) pgbench is a contrib program,
> b) the changes do not break the backward compatibility.
>
> I always call for discussions for questionable part. (for example,
> column type change proposal for pgbench tables).

It's not a big deal, but I was under the impression that even in these
circumstances a patch should be posted first, especially if it changes
user visible behaviour.

cheers

andrew