Re: Patch to enable/disable rule on a table

Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Hi all,
>>
>> Here is a patch to support this new PostgreSQL 8.3 feature : the
>> possibility to enable and disable a rule on a table.
>
> Thanks, applied with minor changes:
>
> - Correct the naming of pgRule::iSetEnabled to pgRule::SetEnabled, and
> added iSetEnabled with the correct functionality. In a nutshell, the
> functions prefixed with 'i' are used to setup the internal state of the
> object (usually called by CreateObjects in the appropriate factory), but
> not change it, whilst those without the 'i' actually change the object
> and it's internal state. This was also broken in the Trigger
> enable/disable code which I guess you probably copied - fixed there too.
>

You're right, I copied it... much easier, but alas much error prone :-/

Thanks for the info on the 'i' functions.

> - Added code to prevent the option being offered for rules under views
> as the syntax isn't there to allow rules on views (or rules that make
> views) to be enabled or disabled.
>
> - Re-jigged the menus a touch as they were starting to look a little
> messy with various new options being added.
>

Yes, I thought about this too but didn't find a way to do it properly.

Thanks for all.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com