Re: [PATCHES] msvc, build and install with cygwin in the PATH

Magnus Hagander schrieb:
> Tom Lane wrote:
>
>> Magnus Hagander <magnus@hagander.net> writes:
>>
>>> Andrew Dunstan wrote:
>>>
>>>> I have committed a fix that is somewhat similar to this. The Install.pm
>>>> module needs some love, but that will have to wait till the next cycle.
>>>>
>>> Thanks, Andrew!
>>>
>> Guys, would you comment on whether this patch closes all the open issues
>> that Bruce has listed for the MSVC port on his "pending patches" page?
>> Specifically, the half-dozen messages with "MSVC" in their subjects at
>> http://momjian.us/cgi-bin/pgpatches
>>
>
> It should, but it'd be good if Hannes can confirm that.
>
>
I found two issues:

(a) use the current dir "." instead of "../.." for the *.sample files,
since there are the chdir's to ../../.. resp. to ../../../.. in line 28
resp. 29. Using ../.. would traverse a too large part of the directory
structure.

(b) a <http://www.dict.cc/englisch-deutsch/superfluous.html>superfluous
\ for the "Dictionaries sample files"

see attached diff.

besides from that it works well in my configuration and it solves the
intial issue with cygwin's dir in PATH. Thank you.

-Hannes

*** ../pgsql-cvshead/src/tools/msvc/Install.pm    Sun Sep 23 20:27:59 2007
--- src/tools/msvc/Install.pm    Sun Sep 23 21:24:13 2007
***************
*** 50,56 ****
                                      push(@$sample_files, $File::Find::name);
                              }
                    },
!                      "../.." );
      CopySetOfFiles('config files', $sample_files , $target . '/share/');
      CopyFiles(
          'Import libraries',
--- 50,56 ----
                                      push(@$sample_files, $File::Find::name);
                              }
                    },
!                      "." );
      CopySetOfFiles('config files', $sample_files , $target . '/share/');
      CopyFiles(
          'Import libraries',
***************
*** 81,87 ****
                     [ glob ("src\\backend\\snowball\\stopwords\\*.stop") ],
                     $target . '/share/tsearch_data/');
      CopySetOfFiles('Dictionaries sample files',
!                    [ glob ("src\\backend\\tsearch\\\*_sample.*" ) ],
                     $target . '/share/tsearch_data/');
      CopyContribFiles($config,$target);
      CopyIncludeFiles($target);
--- 81,87 ----
                     [ glob ("src\\backend\\snowball\\stopwords\\*.stop") ],
                     $target . '/share/tsearch_data/');
      CopySetOfFiles('Dictionaries sample files',
!                    [ glob ("src\\backend\\tsearch\\*_sample.*" ) ],
                     $target . '/share/tsearch_data/');
      CopyContribFiles($config,$target);
      CopyIncludeFiles($target);