Re: Issue on compiling pgAdmin trunk

Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Hi,
>>
>> I had an issue when I tried to compile pgAdmin today. I did a complete
>> svn update (I mean I first did rm -rf on my directory, then svn update,
>> then ./configure, then make). gcc is complaining about duplicate use of
>> DebuggerApiVersion :
>>
>> ../pgadmin/include/debugger/dbgPgConn.h:67: error: declaration of
>> 'DebuggerApiVersion dbgPgConn::DebuggerApiVersion()'
>> ../pgadmin/include/debugger/dbgPgConn.h:37: error: changes meaning of
>> 'DebuggerApiVersion' from 'typedef enum DebuggerApiVersion
>> DebuggerApiVersion'
>>
>> So I changed the Enum's name to DebuggerApiVersion_Enum and everything
>> compiles now. Nevertheless, I'm not sure I did right, even if it
>> compiles fine. So, here is my patch.
>>
>> Comments are more than welcome :)
>
> Yeah, I spotted that in the auto-build last night. The fix seems sound,
> but I'm not keen on the name. Perhaps just DebuggerApiVersions (note the
> s)?
>

You're right. DebuggerApiVersions is a much better name.

> Anyhoo, please commit if you have a minute.
>

Done.

Thanks.


--
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->