Re: Updateable cursors patch

 >
 > maybe just send a better error message

I do the transformation of a where current of clause into where clause
at the analyze stage itself(which is the right place to do. I think).
Hence this error. If I can postpone this transformation until after
re-write then the usual error will be thrown if there are no rules. It
is easily doable. But I want to confirm if this will break any other
part. I am looking into it now.

Rgds,
Arul Shaji


Jaime Casanova wrote:
> On 5/17/07, Jaime Casanova <systemguards@gmail.com> wrote:
>> On 5/17/07, FAST PostgreSQL <fastpgs@fast.fujitsu.com.au> wrote:
>> > No. It works with scrollable cursors. It will work for cursors/selects
>> > which does not put the results in some store, such as WITH hold/group
>> > by/order by etc.... But most of these restrictions apply for normal
>> > 'Select for update' anyway. (With the order by clause, the
>> > implementation is as per the sql standards.)
>> >
>>
>> your patch doesn't work with updatable views because they don't have
>> ctid columns....
>>
>> ERROR:  column "ctid" does not exist
>> STATEMENT:  update vfoo set des_cta = des_cta || ' - prueba' where
>> current of foo;
>> ERROR:  current transaction is aborted, commands ignored until end of
>> transaction block
>>
>> is this sane behavior? to accept create cursors for update on views
>> and then failing to update "where current of" and rollback the entire
>> transaction?
>>
>> comments?
>>
>
> maybe just send a better error message
>