Re: Crashing v1.6.2 with a syntax error

Erwin Brandstetter wrote:
> Hi developers! Hi Dave!

Hi Erwin,


> Testing pgAdmin III v1.6.2 rev: 5837, client Win XP, host Debian Sarge,
> PG 8.1.4. / Debian Etch, PG 8.2.1.
> 
> I have found a 'reliable' way to crash pgAdmin. Look at the following
> query:
>     select * from loc where loc like 'a%' loc = 'b';
> Note the syntax error: "and" is missing in the WHERE clause. If I run
> this from the SQL query dialogue window I get an error message with only
> the error code - but that has been reported before.
> 
>    FEHLER: Fehler »Syntaxfehler« bei »loc«
>    SQL state: 42601
>    Character: 1
> 
> However, if I open the edit grid with a filter and enter the faulty
> WHERE clause, pgAdmin crashes.
> I have run tests with a variety of tables and operators in PG 8.1.4 and
> PG 8.2.1. Any of the following WHERE clauses triggers a crash.
>    fld1 like 'a%' fld2 = 'b'
>    fld1 = 'a%' fld2 = 'b'
>    fld1 = 'a%' fld1 = '%a%'
>    ...
> 
> The "essential" part ist the "%" at the end of the first string.

Yeah, in some cases that string was going through a printf variant, so
it was trying to expand the %. Fixed for 1.6.3.

> After that the error message was scrambled differently:
>    loc = '%a' loc = ''

Yeah, it would have been unpredictable because of the bug above. Can you
test the SVN code please, and let me know if there's still a problem.

Cheers, Dave.