Re: Suggestions for improving \conninfo output in v18

On 2025/06/04 20:18, Fujii Masao wrote:
>
>
> On 2025/06/03 20:22, Robert Treat wrote:
>> +1 on the idea to put it there; if someone gets confused about the
>> behavior, that seems like the place they'd go to look it up. Though I
>> would wordsmith the patch a little:
>>
>> +          Note that the <structfield>Client User</structfield> field
>> shows the user at the time
>> +          of connection, while the
>> <structfield>Superuser</structfield> field indicates
>> +          whether the current user (in the current execution context) has
>> +          superuser privileges. These users are usually the same, but they can
>> +          differ, for example, if the current user was changed with the
>> +          <command>SET ROLE</command> command.
>
> This looks good to me, thanks for the review! I've updated the patch (0002)
> as you suggested and attached it.

Barring any objections, I will commit this patch.


> I've also re-attached the 0001 patch that makes \conninfo report the full
> protocol version, it's the same as the one I posted earlier in the thread.

The 0001 patch changes \conninfo to report the full protocol version (e.g., 3.2)
instead of just the major version (e.g., 3). This is technically a behavior change,
but since protocol version 3.2 was introduced in v18, and both 3.0 and 3.2 are
now valid, always showing just "3" isn't very helpful. To see which protocol
version is actually in use, showing the full version is more informative.

Therefore I see this as fixing an oversight in commit bba2fbc6238, so I'd like to
commit the 0001 patch as well in v18. Thought?

Regards,

--
Fujii Masao
NTT DATA Japan Corporation