Re: [PATCHES] [COMMITTERS] pgsql: /contrib/cube improvements:

I am uncomfortable with the fact that the ordering is different on 
different architectures. AFAIK, all I did was port the ordering function 
from V0 to V1.

Short of me continually submitting patches until I fix it, is there an 
easier way, or some pointers as to what I should be looking for in the code?

The function in question, I believe, is cube_cmp_v0().

Josh

Andrew Dunstan wrote:
> I wrote:
> 
>>
>> I have applied this and made an attempt to fix 
>> cube/expected/cube_1.out - we will still need to keep an eye on the 
>> various cube tests.
>>
> 
> It looks like with the current tests we will need at least one more 
> possible results file (gazelle and asp on buildfarm agree about negative 
> zero but disagree about ordering, so we would need to handle both 
> variants which were previously handed in just cube_1.out). That would 
> make four for this little module. Is it just me or does that seem 
> excessive? Can we possibly simplify things a bit?
> 
> cheers
> 
> andrew

-- 
Joshua Reich
Finance and Corporate Development
ROOT Exchange, A Division of ROOT Markets
601 W. 26th St. / Suite 1500
New York, NY 10001
W - (212) 645 6320 x 7101
M / T - (646) 427 7959
E - josh@rootexchange.com