Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Stating the obvious, again - attached is my patch for earthdistance.

Apologies for breaking the build.

Josh


Joshua Reich wrote:
> Ok. If I understand this correctly, earthdistance required cube. So,
> I'll fix the test for earthdistance to work with the new cube code.
>
> The problem is that there are new functions in cube.sql, so the output
> is now different and breaks the diff (to state the obvious).
>
> Josh Reich
>
>
> Tom Lane wrote:
>> Joshua Reich <josh@root.net> writes:
>>
>>> Can you point to me where I can get a regression diff for a failed
>>> build.
>>>
>>
>> It's all on the webpage, just scroll down ...
>>
>>             regards, tom lane
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 4: Have you searched our list archives?
>>
>>                http://archives.postgresql.org
>>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo@postgresql.org so that your
>       message can get through to the mailing list cleanly

? earthdistance.sql
? regression.diffs
? regression.out
? results
Index: expected/earthdistance.out
===================================================================
RCS file: /projects/cvsroot/pgsql/contrib/earthdistance/expected/earthdistance.out,v
retrieving revision 1.9
diff -c -r1.9 earthdistance.out
*** expected/earthdistance.out    14 Mar 2006 22:48:18 -0000    1.9
--- expected/earthdistance.out    26 Jul 2006 03:48:34 -0000
***************
*** 8,14 ****
  \set ECHO none
  psql:../cube/cube.sql:10: NOTICE:  type "cube" is not yet defined
  DETAIL:  Creating a shell type definition.
! psql:../cube/cube.sql:15: NOTICE:  argument type cube is only a shell
  --
  -- The radius of the Earth we are using.
  --
--- 8,16 ----
  \set ECHO none
  psql:../cube/cube.sql:10: NOTICE:  type "cube" is not yet defined
  DETAIL:  Creating a shell type definition.
! psql:../cube/cube.sql:14: NOTICE:  return type cube is only a shell
! psql:../cube/cube.sql:18: NOTICE:  return type cube is only a shell
! psql:../cube/cube.sql:23: NOTICE:  argument type cube is only a shell
  --
  -- The radius of the Earth we are using.
  --