Re: [HACKERS] kerberos related warning

Joe Conway wrote:
> I just noticed this warning:
>
> gcc -O -Wall -Wmissing-prototypes -Wpointer-arith -Winline
> -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -g
> -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -fpic
> -DFRONTEND -I. -I../../../src/include -D_GNU_SOURCE  -I/usr/include/et
> -I../../../src/port  -c -o fe-auth.o fe-auth.c -MMD
> fe-auth.c: In function 'pg_fe_getauthname':
> fe-auth.c:573: warning: passing argument 1 of 'free' discards qualifiers
> from pointer target type
>
> I think the attached is the appropriate fix. Any objections?

(moved to patches)

Applied.

Joe
Index: src/interfaces/libpq/fe-auth.c
===================================================================
RCS file: /opt/src/cvs/pgsql/src/interfaces/libpq/fe-auth.c,v
retrieving revision 1.115
diff -c -r1.115 fe-auth.c
*** src/interfaces/libpq/fe-auth.c    20 Jun 2006 19:56:52 -0000    1.115
--- src/interfaces/libpq/fe-auth.c    4 Jul 2006 17:27:15 -0000
***************
*** 188,197 ****


  /*
!  * pg_krb5_authname -- returns a pointer to static space containing whatever
!  *                       name the user has authenticated to the system
!   */
! static const char *
  pg_krb5_authname(char *PQerrormsg)
  {
      char *tmp_name;
--- 188,197 ----


  /*
!  * pg_krb5_authname -- returns a copy of whatever name the user
!  *                       has authenticated to the system, or NULL
!  */
! static char *
  pg_krb5_authname(char *PQerrormsg)
  {
      char *tmp_name;
***************
*** 520,526 ****
  pg_fe_getauthname(char *PQerrormsg)
  {
  #ifdef KRB5
!     const char *krb5_name = NULL;
  #endif
      const char *name = NULL;
      char       *authn;
--- 520,526 ----
  pg_fe_getauthname(char *PQerrormsg)
  {
  #ifdef KRB5
!     char       *krb5_name = NULL;
  #endif
      const char *name = NULL;
      char       *authn;