Re: Curious bug in buildfarm files-changed links
От | Andrew Dunstan |
---|---|
Тема | Re: Curious bug in buildfarm files-changed links |
Дата | |
Msg-id | 44935FF6.9050805@dunslane.net обсуждение исходный текст |
Ответ на | Curious bug in buildfarm files-changed links (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Curious bug in buildfarm files-changed links
|
Список | pgsql-hackers |
Tom Lane wrote: >Observe the list of "Files changed this run" at >http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gazelle&dt=2006-06-17%2000:30:01 > >The links to the core-system files are OK but the plpgsql files are not >correct, eg > pgsql/src/gram.y 1.93 >where it should be > pgsql/src/pl/plpgsql/src/gram.y 1.93 > >I'm betting on an overly-greedy regex ... > > Good catch. As usual you are spot on. The offending line is this one, which is parsing CVS status output (if you don't read perl just close your eyes): s!.*Repository revision:.(\d+(\.\d+)+).*(pgsql/.*),v.*!$3 $1!; I think the simplest fix would be just to require a / before the filename capture: s!.*Repository revision:.(\d+(\.\d+)+).*/(pgsql/.*),v.*!$3 $1!; cheers andrew
В списке pgsql-hackers по дате отправления: