Re: [BUGS] BUG #2401: spinlocks not available on amd64

Bruce Momjian wrote:
> Great, changes attached and applied.  I removed the solaris_i386 and
> solaris_x86_64.s files and made just one solaris_x86.s.  I updated the
> build system to use the new file, updated the macros, and added some
> documentation on the approach.  Thanks.
>
> Would you test current CVS to make sure it still works properly?  Thanks.
>

The patch adds an extra else in src/template/solaris that means the
assembly file is not properly picked up.

Also the claim that Sun's cc understands C preprocessor doesn't hold
true for me:

/usr/local/SUNWspro/bin/cc -Xa -v -DSUNOS4_CC -g -c tas.s
Assembler: tas.s
         "tas.s", line 9 : Illegal mnemonic
         "tas.s", line 9 : Syntax error
         "tas.s", line 9 : Illegal mnemonic
         "tas.s", line 9 : Illegal mnemonic

This is with cc -V
cc: Sun WorkShop 6 update 2 C 5.3 Patch 111680-09 2003/05/18
Index: src/template/solaris
===================================================================
RCS file: /projects/cvsroot/pgsql/src/template/solaris,v
retrieving revision 1.26
diff -c -r1.26 solaris
*** src/template/solaris    27 Apr 2006 22:28:42 -0000    1.26
--- src/template/solaris    28 Apr 2006 04:20:02 -0000
***************
*** 4,10 ****
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi
! else
    # Pick the right test-and-set (TAS) code for the Sun compiler.
    # We would like to use in-line assembler, but the compiler
    # requires *.il files to be on every compile line, making
--- 4,10 ----
    if test "$enable_debug" != yes; then
      CFLAGS="$CFLAGS -O"        # any optimization breaks debug
    fi
!
    # Pick the right test-and-set (TAS) code for the Sun compiler.
    # We would like to use in-line assembler, but the compiler
    # requires *.il files to be on every compile line, making