Re: pgxs/windows

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>I doubt DESTDIR is having an effect. From what I can see we hardly use 
>>it so it will mostly be blank:
>>    
>>
>
>Yes, it is often an empty string, which doubtless explains how an error
>of this sort could sneak in.  But I think there's no doubt that one or
>the other of those definitions is wrong.  I'm not completely sure which
>though.  DESTDIR should be included if we are referencing the
>installation tree at build time, but perhaps not for post-install
>purposes, which is the environment that PGXS should deal with.
>  
>


Right.

So we should probably change $(DESTDIR)$(bindir) to $(libdir) in the 
following places:

Makefile.aix:BE_DLLLIBS= 
-Wl,-bI:$(DESTDIR)$(bindir)/postgres/$(POSTGRES_IMP)
Makefile.cygwin:BE_DLLLIBS= -L$(DESTDIR)$(bindir) -lpostgres
Makefile.darwin:BE_DLLLIBS= -bundle_loader $(DESTDIR)$(bindir)/postgres
Makefile.win32:BE_DLLLIBS= -L$(DESTDIR)$(bindir) -lpostgres

But I'm punting slightly on AIX and Darwin, as I know nothing of 
building there.

cheers

andrew


>            regards, tom lane
>
>  
>