Re: pgsql: Rework the pg_statistic_ext catalog

I wrote:
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> OK, it seems the buildfarm is getting green again. I'm not sure why I'm
>> seeing the failure in 011_crash_recovery.pl, while the buildfarm does
>> not. Perhaps my environment is borked in some way? Not sure.

> I see that Coelho's two bleeding-edge-clang animals are reporting that
> failure too.  Normally I'd just ignore those two; they break pretty
> regularly.  Maybe you're using an almost-bleeding-edge clang?

Oh --- I managed to reproduce that failure locally on RHEL6 (nothing
bleeding-edge anywhere), but it went away after make-clean-and-rebuild.
I'm suspicious that the underlying cause was failure to recompile
something that knows the value of CATALOG_VERSION_NO.

This theory is insufficient to explain why Coelho's animals failed,
though.  Maybe it would, if you also posit a ccache screwup?  But it's
not obvious from their configurations that they're using ccache at all.

            regards, tom lane