Re: findoidjoins

Joe Conway <mail@joeconway.com> writes:
> I'm not sure I interpreted the intent of findoidjoins just right, but 
> here it is updated for schemas, new reg* types, using SPI instead of 
> libpgeasy, and returning the results as a table function. Any 
> corrections/comments?

For what we want it for (viz, regenerating the oidjoins test every so
often), this is really a step backwards.  It requires more work to run
than the original program, and it modifies the database under test,
which is undesirable because it's commonly run against template1.

I was thinking of keeping it as a client program, but recasting it to
use libpq since libpgeasy isn't in the standard distribution anymore.

I've looked through my notes and I can't find why I thought findoidjoins
was broken for 7.3.  Did you come across anything obviously wrong with
its queries?
        regards, tom lane