Re: For review: Server instrumentation patch

Bruce Momjian wrote:
> Dave Page wrote:
> 
>> 
>>
>>
>>>-----Original Message-----
>>>From: Bruce Momjian [mailto:pgman@candle.pha.pa.us] 
>>>Sent: 23 July 2005 20:01
>>>To: Dave Page
>>>Cc: PostgreSQL-development
>>>Subject: Re: [HACKERS] For review: Server instrumentation patch
>>>
>>>
>>>This patch looks good.  The only question I have is why you 
>>>didn't want
>>>the pgport rename/unlink calls?

Because I wanted the standard platform behaviour of both. For backend 
storage subsystem purposes, it's certainly necessary to emulate *ix 
behaviour of deleting a file in use, but for generic file access IMHO 
the generic behaviour should be exposed.
Please note that there's some rollback logic in pg_file_rename that 
might break when using the pg_xxx calls.

Regards,
Andreas