Re: multibyte regression tests

Luke Lonergan wrote:

>Andrew,
>
>  
>
>>Good. So should we roll this up into the standard regression suite? Why
>>are these tests separate? Is it just that they need a UTF8 encoded db
>>rather than an SQL-ASCII encoded db?
>>    
>>
>
>I think that was the idea - the src/test/mb kit was already there and was
>designed to create the UTF8 database and controlled circumstances for a
>conversion test, so we used it for the similar testing for COPY.
>
>It could possibly be moved into the "make check" regression suite, if the
>regression DB is always created with UTF8.
>
>Ayush may be able to add to this.
>
>
>  
>

It isn't. But we now have support in pg_regress for specifying the 
database explicitly, and we have just adapted the PL regression sets to 
use the standard infrastructure that the core and contrib regression 
sets use. Moreover, pg_regress.sh already has some support for multibyte 
encodings. So I think rolling up the mb tests at least to use a 
(possibly enhanced) pg_regress.sh would be a GoodThing (tm). Having a 
single and adequately featured regression harness should make adding 
specialised test sets easier - I imagine that would appeal to you guys 
at GreenPlum :-)

cheers

andrew