Re: HOOKS for Synchronous Replication
От | Alfranio Correia Junior |
---|---|
Тема | Re: HOOKS for Synchronous Replication |
Дата | |
Msg-id | 42B7DF64.6050705@lsd.di.uminho.pt обсуждение исходный текст |
Ответ на | Re: HOOKS for Synchronous Replication (Alvaro Herrera <alvherre@surnet.cl>) |
Ответы |
Re: HOOKS for Synchronous Replication
|
Список | pgsql-hackers |
>First of all your patch does not conform with the project style. Please >have a look at how other files are indented, in particular regarding >brace position and ereport() arguments (any function arguments really, >but in ereport your problems are more visible). Also, always use >ereport() for user messages, elog() for conditions that involve >can't-happen situations (server bugs, like not finding a tuple in a >catalog that should be there, etc). > > I think it is ok now. However, I corrected the indentation manually. I could not run some of the tools, namely the "entab". /usr/lib/gcc-lib/i386-redhat-linux/3.3.3/include/varargs.h:4:2: #error "GCC no longer implements <varargs.h>." /usr/lib/gcc-lib/i386-redhat-linux/3.3.3/include/varargs.h:5:2: #error "Revise your code to use <stdarg.h>." halt.c:23: error: syntax error before "va_dcl" halt.c:24: error: syntax error before '{' token ---- Linux alfranio.lsd.di.uminho.pt 2.6.8-1.521 #1 Mon Aug 16 09:01:18 EDT 2004 i686 i686 i386 GNU/Linux(GCC) 3.3.3 20040412 (Red Hat Linux 3.3.3-7) Do you have any idea ? Best regards, Alfranio Junior.
В списке pgsql-hackers по дате отправления: