Re: [PATCH] Appbundle-Support for 1.2

Dave Page wrote:
> Thanks, patch applied.

ok, so here is where I am with 1.2.2 / 1.3.0 and Debian, I'd like Adam
to review the last patch I sent to him. I believe it's not mature enough
to be added to the trunk as is and I may use it "privately" for Debian
releases.
The next patch I'd like to send concerns my packaging files and after
that, if everybody is ok, "let's go for a release" :)

Cheers,
Raphaël


>
>
>>-----Original Message-----
>>From: Raphaël Enrici [mailto:blacknoz@club-internet.fr]
>>Sent: 15 May 2005 21:28
>>To: Dave Page
>>Cc: Florian G. Pflug; pgadmin-hackers@postgresql.org
>>Subject: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>>
>>Dave,
>>
>>attached is the patch which both Florian and I think it solves the
>>DESTDIR issue in Makefile.am.
>>
>>Regards,
>>Raphaël
>>
>>Florian G. Pflug wrote:
>>
>>>Raphaël Enrici wrote:
>>>
>>>
>>>>Dave Page wrote:
>>>>
>>>>
>>>>>>From: blacknoz@club-internet.fr
>>
>>[mailto:blacknoz@club-internet.fr]
>>
>>>>>>Hi Dave, Florian,
>>>>>>
>>>>>>I just took a quick look to the patch provided by Florian. I
>>>>>>didn't try the build yet and I may be wrong, but to me it
>>>>>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>>>>>not DESTDIR.
>>>>>>However, I'll try that tonight. Florian, can you confirm you
>>>>>>were referring to DESTDIR and not PREFIX ?
>>>>>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>>>>
>>>>>Gmake/automake/autoconf is all black magic for me, hence
>>
>>why I'd rather
>>
>>>>>tackle one problem on on OS (that I don't have) at a time :-)
>>>>
>>>>So, let's continue the twist :)
>>>>
>>>>attached is the patch that works for me and keeps what was added by
>>>>Florian. As I understand it, $(PREFIX) is the equivalent to "my"
>>>>$(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
>>>>replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref
>>
>>from Makefile.am.
>>
>>>>Florian, what do you think about it?
>>>
>>>
>>>Dave, please apply Rapahels correction of my patch - I was
>>
>>just being
>>
>>>brain-dead ;-)
>>>
>>>I meant to write "$(DESTDIR)" - but somehow I ended up typing
>>>"$(PREFIX)", and didn't notice because $(PREFIX) is undefined,
>>>and this empty.
>>>
>>>Sorry for the confusion
>>>
>>>greetings, Florian Pflug
>>>
>>>---------------------------(end of
>>
>>broadcast)---------------------------
>>
>>>TIP 6: Have you searched our list archives?
>>>
>>>               http://archives.postgresql.org
>>>
>>
>>
>>--
>> Raphaël Enrici            blacknoz@club-internet.fr
>> -- ICQ: 207246758  / Jabber: blacknoz@jabber.org --
>> -- Use Debian GNU/Linux http://www.debian.org/   --
>> -- Use pgAdmin          http://www.pgadmin.org/  --
>>
>
>


--
 Raphaël Enrici            blacknoz@club-internet.fr
 -- ICQ: 207246758  / Jabber: blacknoz@jabber.org --
 -- Use Debian GNU/Linux http://www.debian.org/   --
 -- Use pgAdmin          http://www.pgadmin.org/  --