Re: Missing program_XXX calling in pgbench tests

On 2025/06/09 13:48, Hayato Kuroda (Fujitsu) wrote:
> Dear Fujii-san,
> 
>> I agree with Peter. I don't think patches 0002 and 0003 are necessary.
>>
>> As for 0004, it adds tests for the short options -? and -V, which
>> duplicate the existing tests for the long options --help and --version.
>> I'm not sure it's worth adding tests just to confirm that the short
>> and long options behave the same.
> 
> Only adding 0004 is not allowed because it can fail due to other commands.
> So let's drop them.
> 
> I verified 0001 can be applied cleanly for all supported branches. To clarify,
> let me attach the 0001 patch again. Please focus on it...

+1 to focusing on the 0001 patch.

Since this isn't a bug fix, I'm not sure back-patching is strictly necessary.
That said, it does improve consistency and test coverage, e.g., by adding checks
like help text length, so I'd be fine with back-patching if others see value in it.

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation