Re: [Proposal] Global temporary tables

On 2020-04-07 10:57, 曾文旌 wrote:

> [global_temporary_table_v24-pg13.patch ]

Hi,

With gcc 9.3.0 (debian stretch), I see some low-key protests during the 
build:

index.c: In function ‘index_drop’:
index.c:2051:8: warning: variable ‘rel_persistence’ set but not used 
[-Wunused-but-set-variable]
  2051 |  char  rel_persistence;
       |        ^~~~~~~~~~~~~~~
storage_gtt.c: In function ‘gtt_force_enable_index’:
storage_gtt.c:1252:6: warning: unused variable ‘indexOid’ 
[-Wunused-variable]
  1252 |  Oid indexOid = RelationGetRelid(index);
       |      ^~~~~~~~
cluster.c: In function ‘copy_table_data’:
cluster.c:780:2: warning: this ‘if’ clause does not guard... 
[-Wmisleading-indentation]
   780 |  if (RELATION_IS_GLOBAL_TEMP(OldHeap));
       |  ^~
cluster.c:781:3: note: ...this statement, but the latter is misleadingly 
indented as if it were guarded by the ‘if’
   781 |   is_gtt = true;
       |   ^~~~~~


Erik