Re: pg_basebackup vs. Windows and tablespaces

<div class="WordSection1"><p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">On</span><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">20August 2014 19:49, Amit Kapila Wrote</span><p
class="MsoNormal"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoNormal">> There are some comments I
wouldlike to share with you<br /> ><br /> >  <br /> ><br /> > 1.      Rebase the patch to current GIT
head.<pclass="MsoNormal">>Done.<p class="MsoNormal"> <p class="MsoNormal" style="margin-bottom:12.0pt">>> +  
                  initStringInfo(&symlinkfbuf);<br /> >><br /> >>             I think declaration and
initializationof symlinkfbuf string can be moved under #ifdef WIN32 compile time macro,<br /> >><br /> >>
forother platform it’s simply allocated and freed which can be avoided.<p class="MsoNormal">>Agreed, I have changed
thepatch as per your suggestion.<p class="MsoNormal" style="margin-bottom:12.0pt">  <br /><span style="color:#1F497D">I
havedone the testing and behavior is as per expectation, </span><p class="MsoNormal" style="margin-bottom:12.0pt"><span
style="color:#1F497D">Dowe need to do some document change? I mean is this limitation on windows is mentioned anywhere
?</span><pclass="MsoNormal" style="margin-bottom:12.0pt"><span style="color:#1F497D">If no change then i will move the
patchto “Ready For Committer”.</span><p class="MsoNormal" style="margin-bottom:12.0pt"><span
style="color:#1F497D"> </span><pclass="MsoNormal" style="margin-bottom:12.0pt"><span style="color:#1F497D">Thanks &
Regards,</span><pclass="MsoNormal" style="margin-bottom:12.0pt"><span style="color:#1F497D">Dilip</span><p
class="MsoNormal"style="margin-bottom:12.0pt"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span></div>