Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]
От | Dilip kumar |
---|---|
Тема | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] |
Дата | |
Msg-id | 4205E661176A124FAF891E0A6BA9135266340046@szxeml509-mbs.china.huawei.com обсуждение исходный текст |
Ответ на | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] (Alvaro Herrera <alvherre@2ndquadrant.com>) |
Ответы |
Re: TODO : Allow parallel cores to be used by vacuumdb [
WIP ]
|
Список | pgsql-hackers |
On 02 July 2014 23:45, Alvaro Herrera Wrote, > > Well, there are (at least) two types of duplicate code: first you have > these common routines such as pgpipe that are duplicates for no good > reason. Just move them to src/port or something and it's all good. > But the OP said there is code that cannot be shared even though it's > very similar in both incarnations. That means we cannot (or it's > difficult > to) just have one copy, which means as they fix bugs in one copy we > need to update the other. This is bad -- witness the situation with > ecpg's copy of date/time code, where there are bugs fixed in the > backend version but the ecpg version does not have the fix. It's > difficult to keep track of these things. In attached patch, I have moved pgpipe, piperead functions to src/port/pipe.c There are some more common function what Jeff and Amit also mentioned to move to common place, Currently I am not sure where we can move other functions to. Can we move other parallel functions to src/port, may be one new file parallel.c under src/port ? Thanks & Regards, Dilip Kumar
Вложения
В списке pgsql-hackers по дате отправления: