Re: Tuplesort merge pre-reading

On 09/10/2016 04:21 AM, Claudio Freire wrote:
> On Fri, Sep 9, 2016 at 9:51 PM, Claudio Freire <klaussfreire@gmail.com> wrote:
>> On Fri, Sep 9, 2016 at 8:13 AM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>>>
>>> Claudio, if you could also repeat the tests you ran on Peter's patch set on
>>> the other thread, with these patches, that'd be nice. These patches are
>>> effectively a replacement for
>>> 0002-Use-tuplesort-batch-memory-for-randomAccess-sorts.patch. And review
>>> would be much appreciated too, of course.
>>>
>>> Attached are new versions. Compared to last set, they contain a few comment
>>> fixes, and a change to the 2nd patch to not allocate tape buffers for tapes
>>> that were completely unused.
>>
>> Will do so

Thanks!

> It seems both 1 and 1+2 break make check.

Oh. Works for me. What's the failure you're getting?

> Did I misunderstand something? I'm applying the first patch of Peter's
> series (cap number of tapes), then your first one (remove prefetch)
> and second one (use larger read buffers).

Yes. I have been testing without Peter's first patch, with just the two 
patches I posted. But it should work together (and does, I just tested) 
with that one as well.

- Heikki