Re: Two bugs found (and patch included)

Xavier Poinsard wrote:
> I just discovered two bugs and attached a patch to correct them :
>
> - the jdbc escaped scalar function dayofweek should return values
> between 1 and 7 (1 for sunday) unlike the backend "extract dow" function
>
> - the literal escaped values for date/time/timestamp were not explicitly
> casted and causing some problems : for example
>   extract( dow from '2005-01-17 12:00:00')
> generate an error, but the following is accepted
>   extract( dow from TIMESTAMP '2005-01-17 12:00:00')

Applied. Thanks for the report & patch.

While testing this patch I noticed we have existing date-related
regression failures (not related to the patch) against 7.2.x:

>     [junit] Testcase: testSetTimestampWTZ(org.postgresql.test.jdbc2.TimestampTest):     Caused an ERROR
>     [junit] ERROR:  Bad timestamp external representation '2000-02-08 04:00:00.120000+1300'
>     [junit] org.postgresql.util.PSQLException: ERROR:  Bad timestamp external representation '2000-02-08
04:00:00.120000+1300'
...
>     [junit]     at org.postgresql.test.jdbc2.TimestampTest.testSetTimestampWTZ(TimestampTest.java:100)

>     [junit] Testcase: testSetTimestampWOTZ(org.postgresql.test.jdbc2.TimestampTest):    Caused an ERROR
>     [junit] ERROR:  Bad timestamp external representation '2000-02-07 15:00:00.120000+1300'
>     [junit] org.postgresql.util.PSQLException: ERROR:  Bad timestamp external representation '2000-02-07
15:00:00.120000+1300'
...
>     [junit]     at org.postgresql.test.jdbc2.TimestampTest.testSetTimestampWOTZ(TimestampTest.java:210)

Is it worth fixing this?

-O