Re: dropdb/contrib-regression

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>
>
>>I guess we could put a small sleep before dropdb in pg_regress.sh to
>>
>>
>
>I'd prefer to put it in contrib/Makefile's installcheck rule, so that
>we don't pay the price in contexts where it's not needed.
>
>

tiny patch attached. For reasons Tom cited related to scheduler it isn't
guaranteed to fix the problem, only to lower the likelihood of occurrence.

>A more radical solution would be to tweak libpq's PQfinish() to be a
>synchronous close, ie, wait for the backend to exit before returning.
>I think we've speculated about doing that in the past, but never been
>fully convinced that it's worth the downside of usually-unnecessary
>client delay.
>
>

Sufficient unto the day .... seems to me making it synchronous could be
a cure as bad as the disease.

cheers

andrew



Index: contrib/Makefile
===================================================================
RCS file: /home/cvsmirror/pgsql/contrib/Makefile,v
retrieving revision 1.52
diff -c -r1.52 Makefile
*** contrib/Makefile    4 Nov 2004 06:09:17 -0000    1.52
--- contrib/Makefile    14 Dec 2004 01:38:00 -0000
***************
*** 60,63 ****
--- 60,64 ----
  all install installdirs uninstall clean distclean maintainer-clean check installcheck:
      @for dir in $(WANTED_DIRS); do \
          $(MAKE) -C $$dir $@ || exit; \
+         sleep 2 ; \
      done