Re: Add remove duplicate slashes to canonicalize_path()
| От | Andrew Dunstan |
|---|---|
| Тема | Re: Add remove duplicate slashes to canonicalize_path() |
| Дата | |
| Msg-id | 418D875C.9010904@dunslane.net обсуждение исходный текст |
| Ответ на | Add remove duplicate slashes to canonicalize_path() (Bruce Momjian <pgman@candle.pha.pa.us>) |
| Ответы |
Re: Add remove duplicate slashes to canonicalize_path()
|
| Список | pgsql-patches |
Bruce Momjian wrote:
>*** 247,255 ****
> int len = strlen(path);
>
> if (len > 2 && strcmp(path + len - 2, "/.") == 0)
>- {
> trim_directory(path);
>- }
> else if (len > 3 && strcmp(path + len - 3, "/..") == 0)
> {
> trim_directory(path);
>
>
>
As a matter of style I hate this. Stripping the braces from a branch of
an if statement on the ground that it only has one statement, when other
branches might be multi-statement blocks is just downright ugly. I
thought the outcome of a recent discussion was that we would stop doing
that, at least automatically from pgindent, but I don't see any reason
to do it manually either.
cheers
andrew
В списке pgsql-patches по дате отправления: