Re: rmtree() failure on Windows

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>Shown below is an extract from the traces of make installcheck in 
>>contrib. It is decorated with some extra traces I built into 
>>src/port/dirmod.c::rmtree(). It shows quite reproducible failure of 
>>rmtree(), mostly at the rmdir calls, but even more worryingly there are 
>>consistent unlink failures also.
>>    
>>
>
>I kinda suspect that what you are looking at is a problem with the
>delayed-unlinking feature that we built to cope with Windows' inability
>to unlink open files, ie, it's being a little too slow to do the
>unlinks.  Would you refresh my memory about exactly where and when the
>unlink happens if the initial try fails?
>
>
>  
>

Same file, although Bruce says that looping code is now redundant, as we 
open files in a way that allows unlinking even if they are open.

cheers

andrew