Re: arrayfuncs: fix read of uninitialized mem
| От | Joe Conway |
|---|---|
| Тема | Re: arrayfuncs: fix read of uninitialized mem |
| Дата | |
| Msg-id | 41487C98.4070502@joeconway.com обсуждение исходный текст |
| Ответ на | arrayfuncs: fix read of uninitialized mem (Neil Conway <neilc@samurai.com>) |
| Ответы |
Re: arrayfuncs: fix read of uninitialized mem
|
| Список | pgsql-patches |
Neil Conway wrote: > > Barring any objections, I'll apply the patch within 24 hours. > > *************** > *** 965,978 **** > * (including any overhead such as escaping backslashes), and detect > * whether each item needs double quotes. > */ > ! values = (char **) palloc(nitems * sizeof(char *)); > ! needquotes = (bool *) palloc(nitems * sizeof(bool)); > --- 965,978 ---- > * (including any overhead such as escaping backslashes), and detect > * whether each item needs double quotes. > */ > ! values = (char **) palloc(nitems * sizeof(*values)); > ! needquotes = (bool *) palloc(nitems * sizeof(*needquotes)); Personally I prefer the original style here. And I agree with Tom's nearby comments. But otherwise looks good to me. Joe
В списке pgsql-patches по дате отправления: