Re: log_line_prefix additions

Ed L. wrote:

>Attached also is a patch to comments in sample postgresql.conf file.
>
>Subject: [PATCHES]  log_line_prefix additions
>Date: Wednesday August 25 2004 3:26
>From: "Ed L." <pgsql@bluepolka.net>
>To: pgsql-patches@postgresql.org
>
>This patch against 8.0.0beta1 source adds log_line_prefix options for
>millisecond timestamps (%m), remote host (%h), and remote port (%P).  The
>milliseconds are useful for QPS measurements, and the remote port is
>worthless to us as part of %r.
>
>
>
[snip]

>+                     struct timezone tz = {0, 0};
>+
>+                     gettimeofday(&tv, &tz);
>
>
>



The timezone is pointless. Just pass NULL as the second argument to
gettimeofday().

Also, I don't understand what you mean by the remote port being
"worthless to us as part of %r." Please explain.

cheers

andrew