"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Wed, Dec 7, 2022 at 8:04 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> I'm not sure InputFunctionCallSoft would be an improvement. Maybe
>> InputFunctionCallSoftError would be clearer, but I don't know that it's
>> much of an improvement either. The same goes for the other visible changes.
> InputFunctionCallSafe -> TryInputFunctionCall
I think we are already using "TryXXX" for code that involves catching
ereport errors. Since the whole point here is that we are NOT doing
that, I think this naming would be more confusing than helpful.
> Unrelated observation: "Although the error stack is not large, we don't
> expect to run out of space." -> "Because the error stack is not large,
> assume that we will not run out of space and panic if we are wrong."?
That doesn't seem to make the point I wanted to make.
I've adopted your other suggestions in the v4 I'm preparing now.
regards, tom lane