Re: pgxs: build infrastructure for extensions v4

Mark Cave-Ayland wrote:

>Peter/Fabien,
>
>Just to say thank you for all your hard work in getting pgxs working in
>CVS. I've successfully managed to get a contrib module to build outside
>of the source tree, which will help simplify a lot of things.
>
>I have one question though: the comments in pgxs.mk suggested that I
>needed to do the following to include the pgxs.mk:
>
># Use the following layout for your Makefile:
>#
>#   [variable assignments, see below]
>#   [custom rules, rarely necessary]
>#
>#   PGXS := $(shell pg_config --pgxs)
>#   include $(PGXS)
>
>
>However, on my CVS version from about an hour ago, I needed to change
>this to:
>
>    PGXS := $(shell pg_config --pgxs)/src/makefiles/pgxs.mk
>    include $(PGXS)
>
>This is because I only get the pgxs directory returned by "pgconfig
>--pgxs" as opposed to the path to the pgxs.mk file itself - is that the
>correct thing to do (i.e. the comment is wrong?) or is "pgconfig --pgxs"
>returning the wrong thing?
>
>
>
>  
>

needs to be fixed in pg_config.c I think - should be a one-liner.

cheers

andrew